- fixes bug introduced in 0.4.17 in which assign app toggle bar didn’t collapse
- allows binary files to be assigned in
ghqc_assign_app()
- fixes bug in which file names with spaces aren’t recognized
- fixes bug in which tables don’t hold position in QC Records
- modifies wrapping in Milestone and Issue summary table columns
- fixes bug in which “—” isn’t escaped in markdown
- fixes bug in which tables run off the page vertically
- fixes bug in pre-app error checking in which an unset upstream branch is uncaught
changes to ghqc_resolve_app()
:
- changes button at the bottom of app from “Post Comment” to “Preview Comment” because the button itself doesn’t post the comment
- fixes glue parsing bugs in which variables don’t exist in the case of errors
- fixes commit log to shell out instead of calling
gert::git_log
which omits commits from merges
- fixes commit log to only retrieve remote commits so that running the app on any local branch does not interfere with the log
- fixes bug in which comments cannot be more than 65536 characters - for large file diffs, a link comparing the “previous” and “current” commits is provided for QCer reference
changes to ghqc_record_app()
:
- changes references to old terms “report” and “record” with new standardized term “QC Record”
- copies rmd file and its sourced files to QC Record directory in case of error in app
- fixes bullet point HTML syntax in app warning modal
- fixes bug in which comment bodies with markdown syntax (like in-line code) didn’t render in QC Record
- fixes bug in which checklist headers weren’t given their own line in QC Record rendering
- fixes bug with rlang %||% operator preventing the use of the Associate Relevant Files feature
- allows metadata bullet parsing to recognize both
*
and -
characters.
- fixes error in Associate Relevant Files modal pop-up
- fixes HTTP 404 error caused in attempts to download images from Issue comments
-
ghqc_record_app()
returns in cases of errors instead of returning a modal pop-up
- In
tryCatch
s, e$message
is replaced with conditionMessage(e)
- increases max number of commits in
gert::git_log()
to 9999
- changes how current commit is calculated by using first element of
get_commits_df$commit
instead of first commit in git log from HEAD
- fixes bug in
ghqc_resolve_app()
in which get_commits_df failed with error “argument of length 0” in the case of diverging branches not getting the entire git log.
- fixes bug in
ghqc_record_app()
in which QC records were unable to be generated due to missing “qc type” from metadata in ghqc-generated issues since metadata simplification in ghqc 0.4.0
- re-formats summary tables in QC Records given missing “qc type”” column
- removes
get_author
call from ghqc_record
and replaces with author retrieved in Issue metadata
- in Milestone summary table in QC Records, adds spaces between listed Issues in Milestones
- removes author and collaborators from QC Data section in QC Records as this is redundant with Issue metadata
- fixes bug in
ghqc_assign_app()
in which “No assigned QCer” isn’t an option as soon as a QCer is selected for a QC file
- fixes bug in which QCer is un-selectable if relevant files are selected for a QC file
- fixes bug in which QCers dropdown caused error for selected files outside of the root directory
- fixes bug in md5 hashes in resolve comment metadata to make hashes correct
- provides additional error handling in the resolve app in the case that the git branch isn’t present in a given Issue’s metadata section
- fixes bug in resolve for Issues created in different branches that haven’t been fetched locally
- fixes a bug in parsing a glue component
- Updates the custom configuration options repository (now
GHQC_OPTIONS_REPO
) check to reflect the following changes:
- The “note” file within the custom configuration repository is now
prepended_checklist_note
within “options.yaml”
-
checklist_display_name_var
in “options.yaml” provides option to change the name in which the QC checklists are referred to as.
Inclusive of 0.1.9, 0.1.10, 0.1.11 changes:
- Adding the branch and a link to the file contents at the start of QC to the Metadata section of Issues created by the Assign app. Also added links to the file contents at the previous and current commits in the metadata section of the resolve app comments.
- Adds “ghqc” label to all GitHub Issues created by ghqc. Only Issues with this label, and the Milestones containing them, will be viewable/selectable in the apps. This change is NOT backward compatible with Issues/Milestones created in previous versions
- Clarifies language in Warning and Error modals for all three apps
- Adding the branch and a link to the file contents at the start of QC to the Metadata section of Issues created by the Assign app. Also added links to the file contents at the previous and current commits in the metadata section of the resolve app comments.
- Adds “ghqc” label to all GitHub Issues created by ghqc. Only Issues with this label, and the Milestones containing them, will be viewable/selectable in the apps. This change is NOT backward compatible with Issues/Milestones created in previous versions
- Clarifies language in Warning and Error modals for all three apps
- Removes reset button in record app modal for users to click after closing milestones when no closed milestones exist (was buggy in viewer panel)
- Fixes bug in rendered reports in which a maximum height for logos wasn’t set to prevent overlapping header lines and header text.
- Fixes bug in record app for previewing markdown files (same bug and solution as in 0.1.4)
- Fixes bug in assign and resolve apps - error checking did not catch remote changes to the directory because checks did not git fetch first
- Fixes bug in resolve app for previewing markdown files
- Changes “No Existing Milestones”” to “No Open Milestones” in ghqc_assign_app() Existing Milestones dropdown menu
- Fixes bug in record app warning modal pop-up for unclosed milestones/issues/checklist items: Milestone link wasn’t clickable
- Improves “No closed milestones” modal pop-up warning in record app. Language change to “It is recommended to close milestones” and adds a reset link to modal for users to click after closing milestones.
In the case when someone sets the standard gh environment variable GITHUB_API_URL, each app checks if this URL matches the actual set remote URL. The function that gets the GITHUB_API_URL did not explicitly return a value.
Small grammar fix in error message from apps in the case that the checklists directory isn’t in the cloned info repo.
- rename ghqc to ghqc.app and ghqc.launcher to ghqc